macOS room dialog's save button

User avatar
Vadi
Posts: 4703
Joined: Sat Mar 14, 2009 3:13 pm

macOS room dialog's save button

Post by Vadi » Thu May 17, 2018 4:25 pm

As mentioned here, there's an issue with the room exits dialog on mac OS.

SlySven took a stab at fixing it, does https://transfer.sh/rodjR/Mudlet-3.9.0- ... d407d9.dmg work better?

Jor'Mox
Posts: 1099
Joined: Wed Apr 03, 2013 2:19 am

Re: macOS room dialog's save button

Post by Jor'Mox » Thu May 17, 2018 6:48 pm

No apparent change with this version, sorry.

User avatar
SlySven
Posts: 919
Joined: Mon Mar 04, 2013 3:40 pm
Location: Deepest Wiltshire, UK
Discord: SlySven#2703

Re: macOS room dialog's save button

Post by SlySven » Fri May 18, 2018 7:48 pm

It is blooming weird - but it only affects macOs at the moment! ;)

One thing I did note was that the Travis CI build - the source of what I imaging you are using is a Release build made using Qt 5.10 - which is later than the Windows or Linux CI builds. If there is anyone who can build Mudlet from sources on the macOs it would be very helpful if they could investigate what is happening in (void) dlgRoomExits::slot_checkModified() in a debug build (so they can inspect the variables) when the doors of an exit is changed - is it detecting a change and reaching the end of the method with (bool) isModified set to true... :ugeek:

Jor'Mox
Posts: 1099
Joined: Wed Apr 03, 2013 2:19 am

Re: macOS room dialog's save button

Post by Jor'Mox » Fri May 18, 2018 8:45 pm

Just for reference, I checked back with different versions, and in version 3.6.1 things work properly here, but they don't work in 3.7. I figured that might help pin down the source of the problem.

User avatar
SlySven
Posts: 919
Joined: Mon Mar 04, 2013 3:40 pm
Location: Deepest Wiltshire, UK
Discord: SlySven#2703

Re: macOS room dialog's save button

Post by SlySven » Sat May 19, 2018 1:05 am

Guess what - there is no change in the Mudlet source code in the dlgRoomExits class between 3.6.1 and 3.7.1!!! Indeed since 3.6.1 the only change up to 3.9.0 was a missing check for the out exit door changing being added in (and what was added cannot have caused this issue) and some spelling errors fixed in some texts.

User avatar
Vadi
Posts: 4703
Joined: Sat Mar 14, 2009 3:13 pm

Re: macOS room dialog's save button

Post by Vadi » Sat May 19, 2018 5:24 am

Thanks for doing that research, Jor'Mox. 3.6.1 was built using Qt 5.9.3 and 3.7.1 was built using 5.10.0 - perhaps the issue is indeed in the Qt version difference?

We'll see if we can build using 5.9.3 (or 5.9.5, I think that is the latest in 5.9 LTS series) to check for the issue.

User avatar
keneanung
Site Admin
Posts: 94
Joined: Mon Mar 21, 2011 9:36 am
Discord: keneanung#2803

Re: macOS room dialog's save button

Post by keneanung » Sat May 19, 2018 12:31 pm

Building the latest with Qt 5.9 might be hard as we'd have to install Qt through other means than homebrew. We can do another test more easily: check 3.6.1 built with 5.10 for the issue. I'll add a link later as this can't be done through travis either :(

Jor'Mox
Posts: 1099
Joined: Wed Apr 03, 2013 2:19 am

Re: macOS room dialog's save button

Post by Jor'Mox » Sat May 19, 2018 1:51 pm

While I get that it is a different issue, the loss of window size permanence for Macs also arose as we moved from 3.6.1 to 3.7, so it would be interesting to see if both problems can be attributed to the version of Qt used, or if there is some other change that potentially caused them both.

User avatar
keneanung
Site Admin
Posts: 94
Joined: Mon Mar 21, 2011 9:36 am
Discord: keneanung#2803

Re: macOS room dialog's save button

Post by keneanung » Sat May 19, 2018 4:22 pm

Okay, after some issues with backwards compatibility of our installer creation scripts, here's the promised link: https://transfer.sh/Ngs1u/Mudlet-3.6.1.dmg

Jor'Mox
Posts: 1099
Joined: Wed Apr 03, 2013 2:19 am

Re: macOS room dialog's save button

Post by Jor'Mox » Sat May 19, 2018 4:47 pm

I can confirm that both issues, the window size impermanence and the save button not visibly enabling when only changing door status of rooms appear in the version of 3.6.1 that you linked here. But since both things should definitely be within the capabilities of Qt, regardless of version, hopefully a way can be found to change the existing code for those two behaviors to get Qt to do what it is supposed to do.

Post Reply

Who is online

Users browsing this forum: No registered users and 132 guests