I note on line 348 of the current code there are multiple comparisons which throw up multiple GCC warnings: "warning: suggest parentheses around comparison in operand of ‘==’" what are these tests supposed to be establishing - is it equality of all four variables because if I recall C/C++ expression evaluation correctly non-equal values such as min_x = -5, min_y = -4, max_x=0, max_y=1 will still cause the overall expression to be evaluated as true?
No, that's a very different meaning. It's good that you bring up custom lines to the agenda because custom lines definitely needs some love. I put this on my todo list.
OK so that bit of code needs some lovin' but what IS it testing for? I was thinking some sort detection that the four variables needed initialisation - and its always good that variables get initialised as I heard that all sorts of weirdness results when uninitialised ones get used...