Some GitHub related questions
Posted: Sat Nov 05, 2016 7:44 am
So I've finally decided to start making contributions beyond forum posts, which means I'm finally going to start using GitHub and trying to put things into pull requests. Got a few (probably) simple questions.
My first thing will be adding in getMousePosition(). It involves a very small amount of changes to TLuaInterpreter.cpp and TLuaInterpreter.h. I've cloned the Mudlet/Mudlet repo via the GitHub Desktop program for Windows, and I modified the two appropriate files. Two initial questions came up:
1.) I'm modifying the source in the Mudlet clone on my computer. When I go to test this change to make sure it's working, should I be compiling it in the cloned Mudlet folder that the GitHub program is watching, or should I be copying the whole src folder to compile and test it elsewhere to avoid having to worry about the created object files and files that require being copied into the release folder(necessary dll's) trying to jump into my commit?
2.) Should my changes be done to a clone of the development branch, should I be doing them to a custom-named branch, or should I be breaking my changes down into a separate branch each(one for getMousePosition, one for a OnReleaseCallback for labels, etc) so they can be PR'd/discussed/pushed separate from each other?
My first thing will be adding in getMousePosition(). It involves a very small amount of changes to TLuaInterpreter.cpp and TLuaInterpreter.h. I've cloned the Mudlet/Mudlet repo via the GitHub Desktop program for Windows, and I modified the two appropriate files. Two initial questions came up:
1.) I'm modifying the source in the Mudlet clone on my computer. When I go to test this change to make sure it's working, should I be compiling it in the cloned Mudlet folder that the GitHub program is watching, or should I be copying the whole src folder to compile and test it elsewhere to avoid having to worry about the created object files and files that require being copied into the release folder(necessary dll's) trying to jump into my commit?
2.) Should my changes be done to a clone of the development branch, should I be doing them to a custom-named branch, or should I be breaking my changes down into a separate branch each(one for getMousePosition, one for a OnReleaseCallback for labels, etc) so they can be PR'd/discussed/pushed separate from each other?