My Github Repository

All and any discussion and development of the Mudlet Mapper.
User avatar
Vadi
Posts: 5042
Joined: Sat Mar 14, 2009 3:13 pm

Re: My Github Repository

Post by Vadi »

I'm not sure why, but sometimes the room 0 will be included in searchRoom results:

table {
0: '?'
419: 'Old Imperial Road'
418: 'Old Imperial Road'
417: 'Old Imperial Road'
416: 'Old Imperial Road'
423: 'Old Imperial Road'
422: 'Old Imperial Road'
421: 'Old Imperial Road'
420: 'Old Imperial Road'
427: 'Old Imperial Road'
426: 'Old Imperial Road'
425: 'Old Imperial Road'
424: 'Old Imperial Road'
431: 'Old Imperial Road approaching bridge'
430: 'Old Imperial Road'
429: 'Old Imperial Road'
428: 'Old Imperial Road'
435: 'Old Imperial Road approaching bridge'
433: 'Old Imperial Road by Delport'
439: 'Old Imperial Road'
438: 'Old Imperial Road'
437: 'Old Imperial Road'
436: 'Old Imperial Road'
443: 'Old Imperial Road'
442: 'Old Imperial Road'
441: 'Old Imperial Road'
440: 'Old Imperial Road'
447: 'Old Imperial Road'
446: 'Old Imperial Road'
445: 'Old Imperial Road'
444: 'Old Imperial Road'
451: 'Old Imperial Road by the Inner Sea'
448: 'Old Imperial Road'
449: 'Old Imperial Road by the Inner Sea'
455: 'Old Imperial Road'
452: 'Old Imperial Road approaching New Celest'
453: 'Old Imperial Road approaching New Celest'
458: 'Old Imperial Road approaching Great Pass'
459: 'Old Imperial Road approaching Great Pass'
456: 'Old Imperial Road'
457: 'Old Imperial Road'
462: 'Old Imperial Road approaching Great Pass'
463: 'Old Imperial Road'
461: 'Old Imperial Road approaching Great Pass'
466: 'Old Imperial Road near Skarch Desert'
467: 'Old Imperial Road near Skarch Desert'
464: 'Old Imperial Road by Dairuchi'
465: 'Old Imperial Road near Skarch Desert'
470: 'Old Imperial Road by lava pools'
471: 'Old Imperial Road approaching Gaudiguch'
468: 'Old Imperial Road by lava pools'
469: 'Old Imperial Road by lava pools'
6002: 'the Oleanvir Valley near Old Imperial Road'
2678: 'a worn path leading away from the Old Imperial Road'
472: 'Old Imperial Road approaching Gaudiguch'
414: 'Old Imperial Road'
415: 'Old Imperial Road'
454: 'Old Imperial Road approaching New Celest'
450: 'Old Imperial Road by the Inner Sea'
}

It can bring some confusion to the user if scripts specifically don't work around it to block it - mind looking at that too?

User avatar
chris
Posts: 493
Joined: Fri Jun 17, 2011 5:39 am

Re: My Github Repository

Post by chris »

I'll check why that might be. Also, I'll see if I can change the text method, I'm interested in seeing a screenshot of your multicolored labels as well if I put that support in

User avatar
Vadi
Posts: 5042
Joined: Sat Mar 14, 2009 3:13 pm

Re: My Github Repository

Post by Vadi »

I'll improve the Lua api to support that once the width will work.

User avatar
chris
Posts: 493
Joined: Fri Jun 17, 2011 5:39 am

Re: My Github Repository

Post by chris »

The width and height now work. For searchRooms, I have nfc why that is happening. The code is very straightforward:
if( pHost->mpMap->rooms->name.contains( QString(room.c_str()), Qt::CaseInsensitive ) )
etc.

It's sort of hard to see how that can find random stuff.

User avatar
Vadi
Posts: 5042
Joined: Sat Mar 14, 2009 3:13 pm

Re: My Github Repository

Post by Vadi »

It would be. Does it happen to you at all? Maybe try searchRoom on every room title in the db?

The fixed width works well, but it seems it has the default 100,100 if the label was created for another Z plane, which is fixed when you enter it:

You scent at the air, your skilled nose picking up the faint traces of others in the surrounding
area.
Svorai: 1337 before the Master Ravenwood Tree
Talan: 1476 under a dark root <- on a levle below
(ex) 5005h, 6930m|100%, 100e%, 10p, 100w%, 99e%, 48.50m ()-

table {
'X': 1
'Width': 100
'Y': -5
'Height': 100
'Z': -2
'Text': 'Talan'
}

table {
'X': 1
'Width': 38
'Y': -1
'Height': 16
'Z': 0 <- on the same Z level
'Text': 'Svorai'
}
The shadow of Svorai suddenly grows longer.
(ex) 5005h, 6930m|100%, 100e%, 10p, 100w%, 100e%, 48.50m ()-
The curled corpse of a spider falls to the ground from the branches of the Master Ravenwood Tree.
(ex) 5005h, 6930m|100%, 100e%, 10p, 100w%, 100e%, 48.50m ()-
Under a dark root. <- went down on that z-level
The shadows violently writhe and twist along the ground here, indicating a war shrine of Nocht
nearby. The shadowy outline of a twisted forest casts a dark gloom here. Suspended from the large
black root hangs a bubbling black cauldron. Dressed in liquid shadows, Rowena Nightshade stands here
regally poised. A black, angry pony with black wings stands here quietly.
You see exits leading north and east.
Rowena Nightshade turns towards you, bowing her head politely.
Rowena Nightshade says, "Mother Night's favour is upon you, Dark Savant."
(ex) 5005h, 6930m|100%, 100e%, 10p, 100w%, 99e%, 48.50m ()-
Rowena Nightshade bows to Talan and commences the lesson in Brewmeister.
(ex) 5005h, 6930m|100%, 100e%, 10p, 100w%, 100e%, 48.50m ()-

table {
'X': 1
'Width': 33 <- it's correct now
'Y': -5
'Height': 16
'Z': -2
'Text': 'Talan'
}
Before the Master Ravenwood Tree.
Brennan Stormcrow paces here, his cadaverous body twitching with sudden jerks. The Master Ravenwood
Tree towers over everything here, pulsing with an immeasurable yet dark power. Casting darkness all
around, a shadow totem thrusts up from the ground, chilling the air. There are 15 dark nighthags
here. There are 5 illithoids scourge here. Its petals glistening with ice, a delicate snoefaasia
orchid grows here from a clump of snow. Covered in bone armour, a furry tarantula crouches here,
ready to pounce on unsuspecting prey. A crudely crafted shrine of harsh black crystal stands here,
thrumming powerfully. A black direwolf is here, blending in with the shadows. A glowing red flame-
shaped sigil has been left here. A blackthorn sapling clings tenaciously to the ground here. In the
shape of an open palm, a metallic sigil lies here. An animated skeleton stands here with a ghostly
outline of a bat around its skull. An animated skeleton stands here with a ghostly outline of a
spider around its skull. An animated skeleton stands here with a ghostly outline of a beetle around
its skull. An animated skeleton stands here with a ghostly outline of a wasp around its skull. A
gruesome scalp lies decomposing on the ground. Smoke curling from her nostrils, a night mare paws
impatiently at the black clouds that roil beneath her hooves.
You see a single exit leading north.
Brennan Stormcrow cocks his head to one side, looking you over with an appraising stare.
Brennan Stormcrow exclaims, "Mighty Crow has his eye upon you, Dark Savant!"
(ex) 5005h, 6930m|100%, 100e%, 10p, 100w%, 99e%, 48.50m ()-

table {
'X': 1
'Width': 33
'Y': -5
'Height': 16
'Z': -2
'Text': 'Talan'
}
Under a dark root.
The shadows violently writhe and twist along the ground here, indicating a war shrine of Nocht
nearby. The shadowy outline of a twisted forest casts a dark gloom here. Suspended from the large
black root hangs a bubbling black cauldron. Dressed in liquid shadows, Rowena Nightshade stands here
regally poised. A black, angry pony with black wings stands here quietly.
You see exits leading north and east.
Rowena Nightshade turns towards you, bowing her head politely.
Rowena Nightshade says, "Mother Night's favour is upon you, Dark Savant."
(ex) 5005h, 6930m|100%, 100e%, 10p, 100w%, 99e%, 48.50m ()-
You scent at the air, your skilled nose picking up the faint traces of others in the surrounding
area.
Svorai: 1337 before the Master Ravenwood Tree
Talan: 1476 under a dark root
(ex) 5005h, 6930m|100%, 100e%, 10p, 100w%, 99e%, 48.50m ()-

table {
'X': 1
'Width': 33
'Y': -5
'Height': 16
'Z': -2
'Text': 'Talan'
}

User avatar
chris
Posts: 493
Joined: Fri Jun 17, 2011 5:39 am

Re: My Github Repository

Post by chris »

I've never encountered that problem with searchroom before. For the labels, the width and height are updated when they're drawn, which is why it shows the non default values after you move levels. Labels aren't predrawn like rooms are, probably because zooming would be a bit funky and some other things as well. It might be worth looking into a cached version of label drawing though since for areas with many labels it seriously slows the map down

User avatar
Vadi
Posts: 5042
Joined: Sat Mar 14, 2009 3:13 pm

Re: My Github Repository

Post by Vadi »

That's fine actually I think, don't worry about it - I can go another way which'll be faster on the label creation as well (by pre-caching the character sizes).

Heiko found a crash, if you scroll the mousewheel over the area list (thus making it change areas quickly), it'll crash eventually. Crashed twice for me at the same point:

Program received signal SIGSEGV, Segmentation fault.
T2DMap::paintEvent (this=0x43243c0, e=<value optimized out>) at T2DMap.cpp:464
464 mRID = mpMap->areas[mViewArea]->rooms.at(0);

Edit: fixed now in latest git, thanks!

User avatar
Vadi
Posts: 5042
Joined: Sat Mar 14, 2009 3:13 pm

Re: My Github Repository

Post by Vadi »

Oh, sorry, got a crash - not sure how, I think it happened when createMapper was called again while one was up?


Program received signal SIGSEGV, Segmentation fault.
0x000000000060db3b in T2DMap::init (this=0x4414d30) at T2DMap.cpp:127
127 if( ! mpMap->areas[kL]->gridMode ) continue;
(gdb) bt
#0 0x000000000060db3b in T2DMap::init (this=0x4414d30) at T2DMap.cpp:127
#1 0x00000000004355b7 in TConsole::createMapper (this=0x2f28ad0, x=1007, y=0, width=432, height=425) at TConsole.cpp:2358
#2 0x00000000004d21c0 in TLuaInterpreter::createMapper (L=0x40020378) at TLuaInterpreter.cpp:2016
#3 0x00007ffff7942a69 in ?? () from /usr/local/lib/libluajit-5.1.so.2

User avatar
Vadi
Posts: 5042
Joined: Sat Mar 14, 2009 3:13 pm

Re: My Github Repository

Post by Vadi »

Another one, and this is on commit 1f6fdade6c131aab9cf5e2e9fb648d8c27ea273b by the way, when starting a profile:


Program received signal SIGSEGV, Segmentation fault.
T2DMap::paintEvent (this=0x42bda90, e=<value optimized out>) at T2DMap.cpp:465
465 mAID = mpMap->rooms[mRID]->area;
(gdb) bt
#0 T2DMap::paintEvent (this=0x42bda90, e=<value optimized out>) at T2DMap.cpp:465
#1 0x00007ffff60a1c7a in QWidget::event(QEvent*) () from /usr/lib/libQtGui.so.4


It's always happening with this map file - I tested it on another profile and the issue is there too - http://ge.tt/9eWXAl8

User avatar
Vadi
Posts: 5042
Joined: Sat Mar 14, 2009 3:13 pm

Re: My Github Repository

Post by Vadi »

Can you please add the bolded files to git ignore? They are autogenerated. (git ignore src/ui_*)

Updating 7d5b05e..d9c8527
Fast-forward
src/TLuaInterpreter.cpp | 1 +
src/ui_about_dialog.h | 4 ++--
src/ui_actions_main_area.h | 4 ++--
src/ui_aliases_main_area.h | 4 ++--
src/ui_color_trigger.h | 4 ++--
src/ui_composer.h | 4 ++--
src/ui_connection_profiles.h | 4 ++--
src/ui_custom_lines.h | 4 ++--
src/ui_extended_search_area.h | 4 ++--
src/ui_irc.h | 4 ++--
src/ui_keybindings_main_area.h | 4 ++--
src/ui_lacking_mapper_script.h | 4 ++--
src/ui_main_window.h | 4 ++--
src/ui_mapper.h | 4 ++--
src/ui_mapper_room_color.h | 4 ++--
src/ui_module_manager.h | 4 ++--
src/ui_notes_editor.h | 4 ++--
src/ui_options_area_actions.h | 4 ++--
src/ui_options_area_aliases.h | 4 ++--
src/ui_options_area_scripts.h | 4 ++--
src/ui_options_area_timers.h | 4 ++--
src/ui_options_area_triggers.h | 4 ++--
src/ui_package_manager.h | 4 ++--
src/ui_package_manager_unpack.h | 4 ++--
src/ui_profile_preferences.h | 4 ++--
src/ui_room_exits.h | 4 ++--
src/ui_scripts_main_area.h | 4 ++--
src/ui_source_editor_area.h | 4 ++--
src/ui_system_message_area.h | 4 ++--
src/ui_timers_main_area.h | 4 ++--
src/ui_trigger_editor.h | 4 ++--
src/ui_trigger_pattern_edit.h | 4 ++--
src/ui_triggers_main_area.h | 4 ++--

33 files changed, 65 insertions(+), 64 deletions(-)

Post Reply